This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
Expose GTO version in FastAPI's interface #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omesser
reviewed
Jun 6, 2023
| root = find_dvc_repo_root(path) | ||
| relpath = os.path.relpath(path, root) | ||
| if relpath.endswith(".mlem"): | ||
| relpath = relpath[:-5] |
There was a problem hiding this comment.
Suggested change
| relpath = relpath[:-5] | |
| relpath = relpath.rstrip(".mlem") |
omesser
suggested changes
Jun 6, 2023
|
|
||
| version = _show_versions(root, name, ref="HEAD") | ||
| if version: | ||
| return version[0]["version"] |
There was a problem hiding this comment.
To make this more flexible and support other version metadata, I suggest version to return a json object and not a string
- GTO version implementation will now return
{"semver": <VERSION>} - obvious next steps in the future would be to add git version information (branch, git rev).
this will also make it possible to return some version information even if there's no GTO tracking and also support other version in the future, like people manually git-tagging, not via gto
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #665
If you do:
git clone https://github.com/iterative/example-gto cd example-gto git checkout mlem mlem --tb serve fastapi -m models/churn.pklYou'll see model version on the last line:
TODO: