Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Fix setup.py classifiers #472

Merged
merged 6 commits into from
Nov 19, 2022
Merged

Fix setup.py classifiers #472

merged 6 commits into from
Nov 19, 2022

Conversation

aguschin
Copy link
Contributor

@aguschin aguschin commented Nov 7, 2022

No description provided.

@aguschin aguschin requested a review from a team as a code owner November 7, 2022 06:11
@aguschin aguschin temporarily deployed to internal November 7, 2022 06:11 Inactive
@mike0sv
Copy link
Contributor

mike0sv commented Nov 7, 2022

Should we also exclude 3.7?

@aguschin aguschin temporarily deployed to internal November 7, 2022 14:49 Inactive
@aguschin aguschin temporarily deployed to internal November 7, 2022 14:50 Inactive
@skshetry
Copy link
Member

skshetry commented Nov 7, 2022

I will suggest considering https://github.com/iterative/py-template (in the future), we maintain a very modern and uptodate Python cookiecutter template.

@aguschin aguschin temporarily deployed to internal November 7, 2022 14:51 Inactive
@aguschin
Copy link
Contributor Author

aguschin commented Nov 7, 2022

@skshetry, in which projects do we use it? Could you please share some examples of that usage and how it's helpful?

@aguschin
Copy link
Contributor Author

aguschin commented Nov 7, 2022

@mike0sv, excluded 3.7.

@skshetry
Copy link
Member

skshetry commented Nov 7, 2022

@aguschin, all of the packages mentioned in https://github.com/iterative/status#other-projects + dql and telemetry-python, 10 packages in total :).

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 60.01% // Head: 85.40% // Increases project coverage by +25.39% 🎉

Coverage data is based on head (f015fd3) compared to base (6b511fd).
Patch coverage: 91.40% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #472       +/-   ##
===========================================
+ Coverage   60.01%   85.40%   +25.39%     
===========================================
  Files          95       96        +1     
  Lines        8135     8255      +120     
===========================================
+ Hits         4882     7050     +2168     
+ Misses       3253     1205     -2048     
Impacted Files Coverage Δ
mlem/cli/main.py 84.58% <ø> (+27.66%) ⬆️
mlem/contrib/catboost.py 98.33% <ø> (+43.10%) ⬆️
mlem/contrib/tensorflow.py 96.33% <ø> (+42.69%) ⬆️
mlem/core/import_objects.py 98.07% <ø> (+26.92%) ⬆️
mlem/core/model.py 94.59% <ø> (+21.62%) ⬆️
mlem/contrib/rabbitmq.py 51.80% <50.00%> (ø)
mlem/contrib/sklearn.py 84.78% <66.66%> (+27.42%) ⬆️
mlem/runtime/server.py 85.29% <78.57%> (-5.19%) ⬇️
mlem/runtime/interface.py 84.61% <84.61%> (+28.36%) ⬆️
mlem/api/commands.py 80.31% <100.00%> (+46.71%) ⬆️
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aguschin
Copy link
Contributor Author

aguschin commented Nov 7, 2022

Thanks @skshetry! Why don't you use it in DVC?

@skshetry
Copy link
Member

skshetry commented Nov 7, 2022

No strong reason tbh. All of those packages came after we had a good template, and we keep dvc in a good enough shape.

There are minor things like .md vs .rst debate (dvc mixes both, template uses rst, tracked inhttps://github.com/iterative/py-template/issues/87), and src/ based directories that template forces (which we are okay with in dvc).

@aguschin aguschin temporarily deployed to internal November 12, 2022 10:43 Inactive
@mike0sv mike0sv mentioned this pull request Nov 12, 2022
Copy link
Contributor

@mike0sv mike0sv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change heroku tests to run on 3.8

@aguschin aguschin temporarily deployed to internal November 15, 2022 05:18 Inactive
@aguschin
Copy link
Contributor Author

Fixed. I guess we should consider moving control over another if-else conditions based on OS and Python (I saw some docker tests that are controlled in code) to GHA workflow as well. WDYT @mike0sv?

@aguschin aguschin self-assigned this Nov 15, 2022
@mike0sv
Copy link
Contributor

mike0sv commented Nov 16, 2022

Maybe, let's do it in another housekeeping issue

@aguschin aguschin temporarily deployed to internal November 17, 2022 15:29 Inactive
@aguschin aguschin mentioned this pull request Nov 17, 2022
@aguschin
Copy link
Contributor Author

@mike0sv, you can approve and merge.
checked this works in #491

@aguschin aguschin merged commit e7753dd into main Nov 19, 2022
@aguschin aguschin deleted the aguschin-patch-1 branch November 19, 2022 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants