Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing ref to api._show_versions #362

Merged
merged 2 commits into from
May 31, 2023
Merged

Allow passing ref to api._show_versions #362

merged 2 commits into from
May 31, 2023

Conversation

aguschin
Copy link
Contributor

Bare minimum needed for iterative/mlem#665

Tasks

Overall, feels like GTO codebase needs a refactoring... While working on this I started with #361, and it's tough to add anything like that without rewriting big chunks of GTO now. There are many things each stepping on other's toes... Plus many implementation decisions were made taking annotations into account, which is no longer a thing in GTO, except for some API for Studio to enable backward compatibility while making updates easier. They should be thrown away to make it easier to contribute new features 🪣

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Patch coverage: 94.73% and project coverage change: +0.21 🎉

Comparison is base (27c2355) 85.15% compared to head (6b90b35) 85.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   85.15%   85.37%   +0.21%     
==========================================
  Files          18       18              
  Lines        2115     2126      +11     
==========================================
+ Hits         1801     1815      +14     
+ Misses        314      311       -3     
Impacted Files Coverage Δ
gto/api.py 89.51% <94.73%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aguschin aguschin merged commit 55bff02 into main May 31, 2023
@aguschin aguschin deleted the feature/show-ref branch May 31, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants