fs: test_links: ignore FileNotFoundError #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
reviewed
Sep 1, 2022
Comment on lines
+172
to
+173
| with suppress(FileNotFoundError): | ||
| to_fs.remove(to_file) |
There was a problem hiding this comment.
Maybe it's worth specializing this function? How many filesystems support linktypes really?
There was a problem hiding this comment.
It's only LocalFileSystem for now, maybe SSHFileSystem in the future.
There was a problem hiding this comment.
Just need to ignore this particular one for now.
Link types are supported by local and sshfs right now. Might look closer at this again later.
There was a problem hiding this comment.
sshfs
does it though? I see fsspec/sshfs#9 still open.
There was a problem hiding this comment.
Oh, good point. Looks like i forgot that we dropped it. But it is first candidate for more link types. I don't think it is worth messing with it right now, but maybe could consider in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all filesystems can silently delete it. Ran into this with adlfs.