Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from cpack.exe to "choco.exe pack". #16749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Jan 4, 2025

Supersedes #15554.

@dkocher dkocher added the installer Windows Installer label Jan 4, 2025
@dkocher dkocher added this to the 9.1.2 milestone Jan 4, 2025
@dkocher dkocher requested review from ylangisc and AliveDevil January 4, 2025 12:41
@dkocher dkocher self-assigned this Jan 4, 2025
@dkocher dkocher requested a review from a team as a code owner January 4, 2025 12:41
@dkocher dkocher mentioned this pull request Jan 4, 2025
@@ -102,6 +100,8 @@
<replacefilter token="${CHECKSUM}" value="${archive.sha256}"/>
<replacefilter token="${COPYRIGHT}" value="${copyright}"/>
</replace>
<exec executable="${cpack.bin}" dir="${chocolatey.target}" failonerror="true"/>
<exec executable="${choco.bin}" dir="${chocolatey.target}" failonerror="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the property choco.bin defined?

@dkocher dkocher modified the milestones: 9.1.2, 9.2 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer Windows Installer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants