Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stevenjin8 as networking maintainer #1548

Closed
wants to merge 2 commits into from

Conversation

Stevenjin8
Copy link
Contributor

@Stevenjin8 Stevenjin8 commented Jan 21, 2025

Hey Folks,

Been contributing for a while and am looking to get maintainership for the networking group. Here are contributions I've made:

There are more across Istio and Envoy.

I've also been active on Slack and Github issues.

@istio-testing
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2025
@Stevenjin8 Stevenjin8 changed the title Add Setevenjin8 as networking maintainer Add Stevenjin8 as networking maintainer Jan 21, 2025
@Stevenjin8 Stevenjin8 marked this pull request as ready for review January 21, 2025 22:56
@Stevenjin8 Stevenjin8 requested a review from a team as a code owner January 21, 2025 22:56
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 21, 2025
@hzxuzhonghu
Copy link
Member

hzxuzhonghu commented Jan 22, 2025

According to our rule, I donot think this is satisfied for networking.

Must remain an active participant in the community by contributing code, performing reviews, triaging issues, etc.

@ramaraochavali
Copy link
Contributor

+1 to @hzxuzhonghu .

@keithmattix
Copy link
Contributor

@hzxuzhonghu @ramaraochavali I see quite a few networking PRs here. Can you two clarify what you would like to see more of here?

@howardjohn
Copy link
Member

The role of a maintainer is primarily the responsibility to approve PRs. It doesn't seem like this is something currently being done at all. I am really happy to see all the increasing work Steven has done, but I would like to see more of the maintainer responsibilities fulfilled beyond just submitting code.

@Stevenjin8
Copy link
Contributor Author

Makes sense. Thanks everybody for your input

@Stevenjin8 Stevenjin8 closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants