Address peer review comments

issuu · Jul 7, 2023 · fe4ccf4 · fe4ccf4
1 parent 050e093
commit fe4ccf4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml
@@ -15,6 +15,11 @@ jobs:
           - 5.0.0
           - 4.14.0
           - 4.04.1
+        include:
+          - lwt: true
+          - async: true
+          - eio: true
+            ocaml-version: 5.0.0
 
     runs-on: ${{ matrix.os }}
 
@@ -35,21 +40,23 @@ jobs:
           opam exec -- dune runtest zmq
 
       - name: zmq-lwt
+        if: matrix.lwt
         run: |
           opam pin add zmq-lwt.dev . --no-action
           opam install --deps-only --with-doc --with-test zmq-lwt
           opam exec -- dune build zmq-lwt
           opam exec -- dune runtest zmq-lwt
 
       - name: zmq-async
+        if: matrix.async
         run: |
           opam pin add zmq-async.dev . --no-action
           opam install --deps-only --with-doc --with-test zmq-async
           opam exec -- dune build zmq-async
           opam exec -- dune runtest zmq-async
 
       - name: zmq-eio
-        if: ${{ matrix.ocaml-version == '5.0.0' }}
+        if: matrix.eio
         run: |
           opam pin add zmq-eio.dev . --no-action
           opam install --deps-only --with-doc --with-test zmq-eio

diff --git a/zmq-eio/test/test.ml b/zmq-eio/test/test.ml
@@ -1,6 +1,5 @@
 open OUnit
 
-(** Sleep is horrible slow, or causing strange slowdowns *)
 let sleepf env secs = Eio.Time.sleep (Eio.Stdenv.clock env) secs
 
 let setup ~sw env =