-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Create the function ComputeClosestPoint to speedup the que… #6719
Open
sebastienmascha
wants to merge
5
commits into
isl-org:main
Choose a base branch
from
sebastienmascha:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8481600
:sparkles: Create the function ComputeClosestPoint to speedup the que…
99e9926
:sparkles: Add changelog and fix bug in output for eigen
46c6b16
:art: Format the code
44b10d9
:art: Format the code python
849ffe5
:sparkles: Add binding for Python compute_closest_point
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -310,6 +310,30 @@ Computes the closest points on the surfaces of the scene. | |
A tensor with the normals of the closest triangle . The shape is | ||
{.., 3}. | ||
|
||
)doc"); | ||
|
||
raycasting_scene.def("compute_closest_point", | ||
&RaycastingScene::ComputeClosestPoint, "query_point"_a, | ||
R"doc( | ||
Computes the closest point on the surface of the scene to a single query point. | ||
|
||
Args: | ||
query_point (open3d.core.Tensor): A tensor with 1 dim, shape {3}, | ||
and Dtype Float32 describing the query point. | ||
The dimension must be 3 and has the format [x, y, z]. | ||
|
||
Returns: | ||
An open3d.core.Tensor representing the closest point on the surface to the | ||
query point. The shape is {3}, and the format is [x, y, z], indicating | ||
the coordinates of the closest surface point. | ||
|
||
Note: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code commits the scene if necessary. Is there a reason for adding this note? |
||
The scene must be committed (prepared for querying) before calling this | ||
function. If the scene has not been previously committed, the function | ||
will commit it automatically. However, for efficiency, it's recommended | ||
to manually commit the scene once all geometries have been added, before | ||
performing any queries. | ||
|
||
)doc"); | ||
|
||
raycasting_scene.def("compute_distance", &RaycastingScene::ComputeDistance, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Input and output are not o3d Tensors but numpy arrays because the function uses Eigen::Vector3.