Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert OpenMP parallelization to OneAPI::TBB #6626

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Convert OpenMP parallelization to OneAPI::TBB #6626

wants to merge 23 commits into from

Commits on Sep 17, 2024

  1. Switched from using OpenMP for parallelism to using oneAPI::TBB (thou… 

    …gh not using the oneapi scope). Untested but building.
    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    46e7d63 View commit details
    Browse the repository at this point in the history

  2. Swichted usage of std::mutex to tbb::mutex for consistency when used … 

    …in conjunction with tbb parallel constructs.
    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0c36784 View commit details
    Browse the repository at this point in the history

  3. Fixed bug in CPU reduction

    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1514fc1 View commit details
    Browse the repository at this point in the history

  4. Shift atomic to outside of RW mutex in PointCloudSegmentation.cpp

    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    31f1e25 View commit details
    Browse the repository at this point in the history

  5. Switch from using a mutex to a concurrent vector for parallelization … 

    …of self intersecting triangles.
    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d7a82f1 View commit details
    Browse the repository at this point in the history

  6. Get maximum threads from TBB instead of OpenMP

    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    181a431 View commit details
    Browse the repository at this point in the history

  7. Updates to ProgressBar.h/.cpp Including separating code for writing t… 

    …he progress bar into its own function and a bulk inplace add function operator+=. Also added TBBProgressBar. It does not inherit from ProgressBar as it uses an atomic for counting and has slightly different internals to use that atomicity.
    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2312299 View commit details
    Browse the repository at this point in the history

  8. Updated ClusterDBSCAN in PointCloudCluster.cpp to bulk update the pro… 

    …gress bar to limit spinning on the mutex.
    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    bd258e3 View commit details
    Browse the repository at this point in the history

  9. Applied Open3D style

    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2789817 View commit details
    Browse the repository at this point in the history

  10. Marked single argument constructors for reductions as explicit to ple… 

    …ase codacy
    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6399001 View commit details
    Browse the repository at this point in the history

  11. Explicitly load atomics in calls to utility::Log*(...) because newer … 

    …versions of format wont automatically convert it to its underlying type.
    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    11c546d View commit details
    Browse the repository at this point in the history

  12. style fix

    @ssheorey @dbs4261
    ssheorey authored and dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f48abcc View commit details
    Browse the repository at this point in the history

  13. Fixed incorrect include in Parallel.h

    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c04077f View commit details
    Browse the repository at this point in the history

  14. Updated ProgressBar.h to use size_t in std namespace for consistency

    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7d6c707 View commit details
    Browse the repository at this point in the history

  15. Switched std::lock_guard<std::mutex> for DiscreteGenerator to use tbb… 

    …::spin_mutex::scoped_lock.
    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    bba01ef View commit details
    Browse the repository at this point in the history

  16. Switch to using tbb::parallel_reduce on all platforms.

    @dbs4261
    dbs4261 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ec98cae View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Fixed progress bar bug that allow for multiple threads writing to the… 

    … terminal.
    @dbs4261
    dbs4261 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dbe4133 View commit details
    Browse the repository at this point in the history

  2. Fixed issue with CPU reduction. Need to exit early if no work is to b… 

    …e done to prevent assignment to the output pointer.
    @dbs4261
    dbs4261 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    25d8e7f View commit details
    Browse the repository at this point in the history

  3. Updated MemoryManagerStatistic to use a tbb::spin_mutex instead of a … 

    …std::mutex
    @dbs4261
    dbs4261 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    929f010 View commit details
    Browse the repository at this point in the history

  4. Updated point cloud segmentation to generate random samples using the… 

    … global mutex from utilities::random.
    @dbs4261
    dbs4261 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    31484e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Updated example usage of global mutex and engine access to reflect th… 

    …e TBB types.
    @dbs4261
    dbs4261 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    81b9bb3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into omp2tbb

    @dbs4261
    dbs4261 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    23ce717 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Turn TBB into publicly linked library

    @dbs4261
    dbs4261 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    86a474d View commit details
    Browse the repository at this point in the history