Feat/selection #2
Conversation
macgeargear
force-pushed
the
feat/selection
branch
from
43c5c37
to
44dc5fd
Compare
There was a problem hiding this comment.
https://github.com/isd-sgcu/onboarding-backend/tree/main/golang/11-logging-error
In the next pr, let's use this standard for the Baan hdr/svc + check if Baan tests have unused dependencies. If so, remove them and init the hdr/svc with nil
macgeargear
force-pushed
the
feat/selection
branch
from
716423a
to
adc1149
Compare
| expectedErr := apperror.BadRequestError("invalid argument") | ||
|
|
||
| context.EXPECT().Bind(t.CreateSelectionReq).Return(expectedErr) | ||
| context.EXPECT().BadRequestError(expectedErr.Error()) |
There was a problem hiding this comment.
context.EXPECT().BadRequestError(apperror.BadRequest)
There was a problem hiding this comment.
this gets rid of expectedErr := apperror.BadRequestError("invalid argument").
If it can be done in 1 line that is not too long, let's do that
There was a problem hiding this comment.
context.EXPECT().BadRequestError(apperror.BadRequest)
i think it should be context.EXPECT().BadRequestError(apperror.BadRequest.Error()) because BadRequestError() takes string and context.EXPECT().BadRequestError(apperror.BadRequest) make test failed
Change made
Describe what you have done
selectionNew Features
Fix
SignUpreturn type to*dto.SignupResponseOthers