Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/baan #1

Merged
merged 10 commits into from
Jun 22, 2024
Merged

Feat/baan #1

merged 10 commits into from
Jun 22, 2024

Conversation

macgeargear
Copy link
Contributor

@macgeargear macgeargear commented Jun 22, 2024

Change made

  •  Bug fixes
  •  New features
  •  Breaking changes

Describe what you have done

  • create baan gateway with a test

New Features

Fix

Others

Screenshot 2024-06-23 at 1 12 53 AM

internal/baan/baan.handler.go Outdated Show resolved Hide resolved
internal/baan/baan.handler.go Outdated Show resolved Hide resolved
internal/baan/baan.service.go Outdated Show resolved Hide resolved
internal/utils/baan.utils.go Outdated Show resolved Hide resolved
internal/utils/baan.utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bookpanda bookpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some name changes please

@bookpanda
Copy link
Contributor

also, let's have the reviewer be the one who clicks the resolve issue so that he can see what was being resolved

@macgeargear macgeargear merged commit bad1fbe into dev Jun 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants