Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/user service #4

Merged
merged 19 commits into from
Dec 31, 2023
Merged

Feature/user service #4

merged 19 commits into from
Dec 31, 2023

Conversation

bookpanda
Copy link
Contributor

@bookpanda bookpanda commented Dec 24, 2023 •
edited
Loading

Screenshot 2566-12-29 at 00 25 20 Screenshot 2566-12-29 at 00 30 11 Screenshot 2566-12-29 at 00 38 54

Screenshot 2566-12-29 at 00 39 09

Implement user service + unit tests

  • FindOne: find one user by id
  • Update: update user with specified id WILL ALSO ACCEPT PASSWORD FIELD
  • Delete: delete user with specified id
- gateway: 3001
- auth: 3002
- backend: 3003
- file: 3004

Nitiwat-owen
Nitiwat-owen requested changes Dec 28, 2023
View reviewed changes
Copy link
Member

@Nitiwat-owen Nitiwat-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should not return password

src/internal/service/user/user.service.go Outdated Show resolved Hide resolved
Nitiwat-owen
Nitiwat-owen requested changes Dec 30, 2023
View reviewed changes
src/internal/service/user/user.service.go Outdated Show resolved Hide resolved
src/internal/service/user/user.service.go Outdated Show resolved Hide resolved
src/internal/service/user/user.service.go Outdated Show resolved Hide resolved
@bookpanda bookpanda merged commit 606d179 into dev Dec 31, 2023
2 checks passed
@bookpanda bookpanda deleted the feature/user-service branch December 31, 2023 14:39
@linear linear bot mentioned this pull request Jan 5, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nitiwat-owen Nitiwat-owen Nitiwat-owen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bookpanda @Nitiwat-owen