Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpackFrame_ROIPAC_raw.py fixes #767

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bjmarfito
Copy link
Contributor

  • Use default values instead of using DOPIQ when focusing images
  • Use os.path.abspath for the image name so stackStripMap.py can read the path of the raw files when processing
  • Change the file format to UNIX using :set ff=unix

@hfattahi
Copy link
Collaborator

hfattahi commented Apr 8, 2024

@bjmarfito was there a reason that you remove the Doppler estimation here?
I doubt if there are Roi_pac users. Not possible for me to test right now. Can you confirm if you have tested and with what kind of data?

@bjmarfito
Copy link
Contributor Author

bjmarfito commented Apr 9, 2024

Hi @hfattahi , I used the unpackFrame_ROIPAC_raw.py to process ROIPAC formatted JERS data. I used the default doppler estimation for JERS data and it worked correctly. I actually can't remember the reason why I removed the DOPIQ since it was many months ago after I submitted this PR. Though, I already brought it back for users who need it and added an argument to either use DEFAULT of DOPIQ for doppler estimation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants