PyCuAmpcor: offer an option to fix the starting pixel locations #722
+356
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 28, 2022 16:17
in this update, * either the starting pixel(corner) or the center of window location may be specified (see README) * by specifying the starting/ending pixel locations, the reference/search window may go beyond the range of the original images. Zeros are filled in instead. In this case, the offset fields at the edge may be incorrect. * The range check is no longer needed. It only runs in DEBUG mode and issues warning messages when pixels are outside the image range.
|
A recent update 51af91d fixes the issue of gpu memory leak when repeating the cuAmpcor processes within the same python script. |
|
@lijun99 sorry for getting to this PR very late. We have had enough with the ISCE3, NISAR etc. Is this PR still the latest or do you want to change anything? |
|
Sorry for my late reply, I was into other things as well. Please consider approving this PR, which includes two major updates
Thanks! @hfattahi @rtburns-jpl @vbrancat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes were made to allow users to fix the coordinate of the first window (center). This will be useful in cases such as 1) to compare the results with different window sizes (center needs to be fixed); 2) to find out the offsets for a particular pixel or a group of pixels.
When the center is fixed, it is possible that some pixels in the window are out of range when the window is close to borders. Zeros are padded for these out-of-range pixels.
The code tidying from #622 is also merged. Thanks, @rtburns-jpl !