Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stac validation #9

Merged
merged 5 commits into from
May 21, 2024
Merged

Stac validation #9

merged 5 commits into from
May 21, 2024

Conversation

datadavev
Copy link
Member

Changed the STAC output to conform with validator.

While working with the stac_browser, found the structure of the STAC content was a bit off. Found a validator at https://github.com/stac-utils/stac-validator which works well. Adjusted the generated STAC record to be valid and now bb and temporal range work as expected in the browser.

Copy link
Member

@dannymandel dannymandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could we add a test for the new temporal extent method in duckdb_utilities.py? There's one for the spatial extent it would be good to have a similar one for temporal.

@dannymandel
Copy link
Member

Also, one other thought I had…is this validator able to accessed programmatically? Would be nice for us to run an automated test that ensures we pass it when we write out the results.

@dannymandel
Copy link
Member

Going to merge this one and will look at getting the stac validator hooked up in a followup PR.

@dannymandel dannymandel merged commit 997bf92 into develop May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants