Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile create pin #94

Merged
merged 19 commits into from
Dec 16, 2024
Merged

Mobile create pin #94

merged 19 commits into from
Dec 16, 2024

Conversation

cgjohn
Copy link
Contributor

@cgjohn cgjohn commented Dec 13, 2024

pin-flow.mp4

implements this flow from figma

dguenther
dguenther approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@dguenther dguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it's functional! Might want to grab a review from Dan as well though since he's probably more informed on the frontend 😄

dgca
dgca approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@dgca dgca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably wanna remove that console.log, but lgtm otherwise

@dguenther dguenther enabled auto-merge (squash) December 16, 2024 20:23
@dguenther dguenther merged commit f030ccb into main Dec 16, 2024
2 checks passed
@dguenther dguenther deleted the mobile-create-pin branch December 16, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgca dgca dgca approved these changes

@dguenther dguenther dguenther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgjohn @dguenther @dgca