Account name for balance command is arg

[patnir]

Summary

Previously, it was a flag. This didn't conform to the standard we have for other commands like address.

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

[hughy]

I think wallet:balance and wallet:balances are borderline cases as far as the style guide is concerned with flags vs. args:

ironfish/ironfish-cli/STYLE_GUIDE.md

Line 24 in 6693fe5

Flags are preferred to args when there are many inputs, particularly inputs of the same type. They involve a bit more typing, but make the use of the CLI clearer. For example, `ironfish wallet:send` used to accept an argument for the account to use, as well as --to flag to specify the account to send to.

I'm curious whether @mat-if and @NullSoldier considered making this an arg during the CLI audit?

[NullSoldier]

Yeah, our stlye guide does indicate this should be a flag here to be consistent with our wallet commands. The only time the command should take an account as an arg is when the account name is the primary operand such as ironfish wallet:use <account>.

My argument would be that address should be a flag.