renderSpan: add more time intervals #5568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-s-n
force-pushed
the
renderSpan-add-more-time-intervals
branch
from
109fdd6 to
4c4e0dc
Compare
NullSoldier
reviewed
Nov 25, 2024
NullSoldier
reviewed
Nov 25, 2024
|
I think we should add a few tests in the test file for these new cases. |
added tests for renderSpan and renderEstimate. Updated renderEstimate to return largest 3 intervals (y, M, d) for longer periods and renderSpan outputs largest 2 intervals (e.g. y, M / M, d / d, h) |
|
Ok the PR looks good. Assuming the tests pass we should merge this in. |
Fixed linting error: added comma after forceMinute
…ved unused tr import
j-s-n
force-pushed
the
renderSpan-add-more-time-intervals
branch
from
aa7f611 to
3130101
Compare
NullSoldier
approved these changes
Jan 4, 2025
NullSoldier
reviewed
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added years, months, and days to renderSpan
Estimated years to 365 days and months to 30 days.
Testing Plan
Lock and unlock a wallet with flags for various time intervals.
Confirmed it returns the highest 2 time units (year & month, month & day, etc.)
Documentation
N/A
Breaking Change
N/A