allows deploying Docker images for staging branch #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughy
force-pushed
the
chore/hughy/docker-branch-name-images
branch
from
b624df6 to
9dfc973
Compare
adds deploy step to deploy to image to github for branch refs
hughy
force-pushed
the
chore/hughy/docker-branch-name-images
branch
from
9dfc973 to
0cc51e0
Compare
|
This will create a lot of Docker images. Will we incur in costs due to this? Do we need a retention policy? |
andiflabs
approved these changes
Apr 1, 2024
I think as an open source project we do not incur costs for these builds. Since all of the images use the same tag I don't think a retention policy is necessary. That said, we could leave 'staging' builds as ad hoc or look at limiting automated builds to only when we do a release. |
dguenther
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds deploy step to deploy to image to github for branch refs
adds rule to deploy docker image on push to staging
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.