standardizing how the account flag is used in our CLI

[patnir]

Summary

These are the ways we enter the account in our CLI:

1. (most common) Using the -f flag
2. As an argument (has it's place, for example when creating an account or changing the name of an account)
3. -a
4. --account

As a user want the experience to be as consistent as possible. Provide the account with the same flag. If the account is not provided, use the default account.

This change goes through our CLI commands and attempts to make the way we enter the account consistent.

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

[patnir]

coins is more consistent with the description of the command and of other fields in the command

[patnir]

by default not required

[danield9tqh]

What does f stand for? Is that short for from? Seems like that makes sense in some contexts but not others when passing an account. -a seems more universal. was there a reason for going with f instead?

[hughy]

I think I might actually prefer to go the opposite way and move towards deprecating single character flags like -f and use the full --account: it's only intuitive to me that f would be an account for send -f(rom)

[patnir]

What does f stand for? Is that short for from? Seems like that makes sense in some contexts but not others when passing an account. -a seems more universal. was there a reason for going with f instead?

I wanted to keep send as is since it's probably the most used command and conform everything to that. I agree a is more intuitive

[patnir]

I think I might actually prefer to go the opposite way and move towards deprecating single character flags like -f and use the full --account: it's only intuitive to me that f would be an account for send -f(rom)

@hughy i feel like single letter is a common pattern for many CLI interfaces, so i personally don't like the idea of deprecating single characters. I agree that --account is more intuitive. Maybe changing everything to -a would be better like @danield9tqh mentioned above?

[andiflabs]

It might be worth to keep (or deprecate, without removing) -f for backward compatibility reasons.

If you want to go the deprecation route, you can add code to detect when it's used and show a warning like "-f is going away in version x.y.z; please switch to -a" (or similar)

[jowparks]

My vote is for keeping -f with deprecation warning, and making -a the universal. I think having single letter flags is useful for power users, having --account is great for newer users.

[patnir]

I reverted the change to send, mint, and burn because the -a flag conflicts with the -a flag for amount. I do believe the remaining changes are still relevant and I'll think of what the best approach for the other commands is.