Remove unnecessary DigestMethod().Reset() calls #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These simply generate a new hash instance, only to call Reset() on it and then discard it, which is a wasted allocation etc. They look to be a hangover from before 7dd818e where DigestMethod used to hold a persistent instance of hash.Hash, and therefore needed resetting before each use.
DigestMethod is already a func() hash.Hash, so there's no longer a need to wrap it in an anonymous function with the same signature to call it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These simply generate a new hash instance, only to call
Reset()on it and then discard it, which is a wasted allocation etc.They look to be a hangover from before #3 where DigestMethod used to hold a persistent instance of
hash.Hash, and therefore needed resetting before each use.While here, I've also removed an unnecessary anonymous function.
DigestMethodis already afunc() hash.Hash, so there's no need to wrap it in an anonymous function with the same signature to call it.