Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#254] Fix specific query for violating query example in README (main) #256

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

korydraughn
Copy link
Collaborator

See issue for the formatted version of the query.

Confirmed, using PostgreSQL, the SQL does not result in an error when run manually. Of course, testing used a different resource id and AVU.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the specific query in TestStorageTieringMultipleQueries as well?

We will probably hit this naturally when testing closer to UGM, but we will need to make sure to update the training slides as well. Not sure if that's worth putting in an issue or if we'll just cross that bridge when we get there.

@korydraughn
Copy link
Collaborator Author

Yes. Can go ahead and do that in this PR.

@korydraughn
Copy link
Collaborator Author

Just need to test it now.

@korydraughn
Copy link
Collaborator Author

TestStorageTieringMultipleQueries passed with the change.

Got it in one too!

@trel
Copy link
Member

trel commented Jan 22, 2024

always nervous about 'in one'... please introduce a typo and watch it not work...

but yes, excellent.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shameless red -> green :)

Once confirmed, I think it's good to go.

@korydraughn
Copy link
Collaborator Author

Broke the query by including an invalid column name and the test failed.
Restored the query to what's included in this PR and the test passed.

@trel
Copy link
Member

trel commented Jan 22, 2024

love it. please to #.

@korydraughn
Copy link
Collaborator Author

#'d

@alanking alanking merged commit 01e605d into irods:main Jan 22, 2024
1 check passed
@korydraughn korydraughn deleted the 254.m branch January 22, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants