-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#254] Fix specific query for violating query example in README (main) #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the specific query in TestStorageTieringMultipleQueries
as well?
We will probably hit this naturally when testing closer to UGM, but we will need to make sure to update the training slides as well. Not sure if that's worth putting in an issue or if we'll just cross that bridge when we get there.
Yes. Can go ahead and do that in this PR. |
Just need to test it now. |
Got it in one too! |
always nervous about 'in one'... please introduce a typo and watch it not work... but yes, excellent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shameless red -> green :)
Once confirmed, I think it's good to go.
Broke the query by including an invalid column name and the test failed. |
love it. please to #. |
#'d |
See issue for the formatted version of the query.
Confirmed, using PostgreSQL, the SQL does not result in an error when run manually. Of course, testing used a different resource id and AVU.