[#233] Add test for replica preservation on restage (main) #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noting that this test passes with the change suggested here: #234 (comment) |
korydraughn
reviewed
Dec 12, 2023
alanking
commented
Dec 12, 2023
This commit adds tests for restaging/tiering out to resources which already have a good replica. The result should be no data movement, and updated metadata to reflect the "tracked" replica.
When tiering out or restaging, a call to the replication API is made. This commit checks to see whether a good replica already exists in the hierarchy and skips the replication if so. This is required because good replicas are not allowed to be overwritten at the risk of losing data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In service of #233
Companion PR for #234
Somewhat tangled up in #235