Wrap up changes

irby · Nov 10, 2023 · a9bff3c · a9bff3c
1 parent df570c3
commit a9bff3c
Show file tree

Hide file tree

Showing 3 changed files with 159 additions and 150 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -5,7 +5,7 @@ on:
       - master
 
 env:
-  NVM_NODE_VERSION: v18.17.0
+  NVM_NODE_VERSION: v20.9.0
 
 jobs:
   linux-lts:
@@ -21,35 +21,35 @@ jobs:
         node -v
         which npm
         npm -v
-  # linux-stable:
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #     with:
-  #       node-version: node
-  #   - name: Check
-  #     run: |
-  #       which node
-  #       node -v
-  #       which npm
-  #       npm -v
-  # linux-exact:
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #     with:
-  #       node-version: "10.0.0"
-  #   - name: Check
-  #     run: |
-  #       which node
-  #       node -v
-  #       which npm
-  #       npm -v
-  #       if [ $(node -v) != "v10.0.0" ]; then
-  #         exit 1;
-  #       fi
+  linux-stable:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+      with:
+        node-version: node
+    - name: Check
+      run: |
+        which node
+        node -v
+        which npm
+        npm -v
+  linux-exact:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+      with:
+        node-version: "10.0.0"
+    - name: Check
+      run: |
+        which node
+        node -v
+        which npm
+        npm -v
+        if [ $(node -v) != "v10.0.0" ]; then
+          exit 1;
+        fi
   linux-nvmrc:
     runs-on: ubuntu-latest
     steps:
@@ -64,119 +64,119 @@ jobs:
         if [ $(node -v) != "$NVM_NODE_VERSION" ]; then
           exit 1;
         fi
-  # linux-canary:
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #     with:
-  #       node-version: latest
-  #       node-mirror: https://nodejs.org/download/v8-canary/
-  #   - name: Check
-  #     run: |
-  #       which node
-  #       node -v
-  #       which npm
-  #       npm -v
-  # windows-lts:
-  #   runs-on: windows-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #     with:
-  #       node-version: lts/*
-  #   - name: Check
-  #     run: |
-  #       node -v
-  #       npm -v
-  # windows-stable:
-  #   runs-on: windows-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #     with:
-  #       node-version: node
-  #   - name: Check
-  #     run: |
-  #       node -v
-  #       npm -v
-  # windows-exact:
-  #   runs-on: windows-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #     with:
-  #       node-version: "10.0.0"
-  #   - name: Check
-  #     run: |
-  #       node -v
-  #       npm -v
-  # windows-nvmrc:
-  #   runs-on: windows-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #   - name: Check
-  #     run: |
-  #       node -v
-  #       npm -v
-  #       if [ $(node -v) != "$NVM_NODE_VERSION" ]; then
-  #         exit 1;
-  #       fi
-  # macos-lts:
-  #   runs-on: macos-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #     with:
-  #       node-version: lts/*
-  #   - name: Check
-  #     run: |
-  #       node -v
-  #       npm -v
-  # macos-stable:
-  #   runs-on: macos-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #     with:
-  #       node-version: node
-  #   - name: Check
-  #     run: |
-  #       node -v
-  #       npm -v
-  # macos-exact:
-  #   runs-on: macos-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #     with:
-  #       node-version: "10.0.0"
-  #   - name: Check
-  #     run: |
-  #       node -v
-  #       npm -v
-  # macos-nvmrc:
-  #   runs-on: macos-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #   - name: Check
-  #     run: |
-  #       node -v
-  #       npm -v
-  #       if [ $(node -v) != "$NVM_NODE_VERSION" ]; then
-  #         exit 1;
-  #       fi
-  # macos-canary:
-  #   runs-on: macos-latest
-  #   steps:
-  #   - uses: actions/checkout@master
-  #   - uses: ./
-  #     with:
-  #       node-version: latest
-  #       node-mirror: https://nodejs.org/download/v8-canary/
-  #   - name: Check
-  #     run: |
-  #       node -v
-  #       npm -v
+  linux-canary:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+      with:
+        node-version: latest
+        node-mirror: https://nodejs.org/download/v8-canary/
+    - name: Check
+      run: |
+        which node
+        node -v
+        which npm
+        npm -v
+  windows-lts:
+    runs-on: windows-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+      with:
+        node-version: lts/*
+    - name: Check
+      run: |
+        node -v
+        npm -v
+  windows-stable:
+    runs-on: windows-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+      with:
+        node-version: node
+    - name: Check
+      run: |
+        node -v
+        npm -v
+  windows-exact:
+    runs-on: windows-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+      with:
+        node-version: "10.0.0"
+    - name: Check
+      run: |
+        node -v
+        npm -v
+  windows-nvmrc:
+    runs-on: windows-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+    - name: Check
+      run: |
+        node -v
+        npm -v
+        if [ $(node -v) != "$NVM_NODE_VERSION" ]; then
+          exit 1;
+        fi
+  macos-lts:
+    runs-on: macos-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+      with:
+        node-version: lts/*
+    - name: Check
+      run: |
+        node -v
+        npm -v
+  macos-stable:
+    runs-on: macos-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+      with:
+        node-version: node
+    - name: Check
+      run: |
+        node -v
+        npm -v
+  macos-exact:
+    runs-on: macos-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+      with:
+        node-version: "10.0.0"
+    - name: Check
+      run: |
+        node -v
+        npm -v
+  macos-nvmrc:
+    runs-on: macos-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+    - name: Check
+      run: |
+        node -v
+        npm -v
+        if [ $(node -v) != "$NVM_NODE_VERSION" ]; then
+          exit 1;
+        fi
+  macos-canary:
+    runs-on: macos-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: ./
+      with:
+        node-version: latest
+        node-mirror: https://nodejs.org/download/v8-canary/
+    - name: Check
+      run: |
+        node -v
+        npm -v
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-18.17.0
+20.9.0
diff --git a/README.md b/README.md
@@ -14,19 +14,28 @@ The node.js mirror to use, e.g. `https://nodejs.org/download/v8-canary/` for nod
 
 ## Example usage:
 
+### Use latest LTS version of Node
+
 ```yaml
 uses: irby/setup-node-nvm@master
 with:
   node-version: lts/*
 ```
 
-```yaml
-uses: irby/setup-node-nvm@master
-```
+### Use current Node version at mirror location
 
 ```yaml
 uses: irby/setup-node-nvm@master
 with:
   node-version: node
   node-mirror: https://nodejs.org/download/v8-canary/
 ```
+
+### Use version specified in .nvm
+Will try to read `.nvmrc` at root level of repository calling the action. 
+
+If this value cannot be read, it will use the `.nvmrc` version defined in this repository.
+
+```yaml
+uses: irby/setup-node-nvm@master
+```