Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory pool backed FS API #67

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

memory pool backed FS API #67

wants to merge 19 commits into from

Conversation

japaric
Copy link
Collaborator

@japaric japaric commented Apr 16, 2020 •
edited
Loading

This PR:

  • changes the FS API to more closely match std::fs API (e.g.fs free functions)
  • it hides all the buffers from the public API by internally using memory pools with automatic deallocation drop. This change also reduces the number of lifetimes parameters in fs types to zero
  • the above point also keeps the API sound in presence of a safe mem::forget (memory leaks)
  • adds sanitizer tests to check that the safe API is indeed sound when it interops with mem::forget

TODOs

  • tweak GHA to run sanitizer tests
  • add back the transactional API
  • make Fs Send
  • RTFM + Fs example

@japaric japaric mentioned this pull request Apr 17, 2020
Closed
3 tasks
@japaric
Copy link
Collaborator Author

japaric commented Apr 20, 2020

last series of commit made the fs API interrupt safe (see RTFM example number 10 for an overview of what this means).

this PR is ready to land.

@japaric
Copy link
Collaborator Author

japaric commented Apr 23, 2020

(Rebased after PR #69 landed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-iqlusion tony-iqlusion Awaiting requested review from tony-iqlusion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@japaric