Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] IBC/ICA Support for simapp #73

Draft
wants to merge 2 commits into
base: sam/global-cap
Choose a base branch
from

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented May 4, 2023

No description provided.


tokensBz, err := tokens.Marshal()
if err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt

var tokens sdk.Int
if err := tokens.Unmarshal(tokensBz); err != nil {
panic(err)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
tokensBz := store.Get(types.TotalLiquidStakedTokensKey)

if tokensBz == nil {
panic("total liquid staked was never initialized")

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@sampocs sampocs changed the title [DRAFT - DO NOT MERGE] IBC Support for simapp [DO NOT MERGE] IBC/ICA Support for simapp May 4, 2023
@sampocs sampocs changed the base branch from master to sam/global-cap May 4, 2023 21:57
@faddat
Copy link
Collaborator

faddat commented May 22, 2023

@sampocs - I think this PR is very important, and would pair well with #71. I had some concerns about some changes you'd made affecting IBC, and this PR would let us know for sure if changes do affect IBC.

I think that I am going to take a number of your PRs, and put them in #80, then make tests pass. My opinion is that we should discontinue lsm development on sdk 46 for the sake of simplicity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants