test: handle liquid staked coins in sim; update sim ops #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing
gaia
integration with a cosmos-sdk branch/PR containing LSM functionality it was discovered that some non-determinism tests ongaia
started failing.Upon further inspection it was noted that the
simtypes.RandFees()
function sometimes tries to use the liquid staked token as a fee denomination.I am unsure wether that's the correct behaviour, but I am suspecting it is not.
The issue is mainly concerning testing and simulations and was caught because
gaia
implements anAnteHandler
that restricts the types of coins that can be used as fee denoms.There was also a small inconsistency in
SimulateMsgTokenizeShares
which I addressed.Reference to
gaia
PR with the LSM-ICS integration:Please let me know if you find these changes acceptable or want further changes made.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: