Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: handle liquid staked coins in sim; update sim ops #21

Merged

Conversation

MSalopek
Copy link

While testing gaia integration with a cosmos-sdk branch/PR containing LSM functionality it was discovered that some non-determinism tests on gaia started failing.

Upon further inspection it was noted that the simtypes.RandFees() function sometimes tries to use the liquid staked token as a fee denomination.

I am unsure wether that's the correct behaviour, but I am suspecting it is not.

The issue is mainly concerning testing and simulations and was caught because gaia implements an AnteHandler that restricts the types of coins that can be used as fee denoms.

There was also a small inconsistency in SimulateMsgTokenizeShares which I addressed.

Reference to gaia PR with the LSM-ICS integration:

Please let me know if you find these changes acceptable or want further changes made.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@MSalopek MSalopek changed the title fix: handle liquid staked coins in sim; update sim ops tests: handle liquid staked coins in sim; update sim ops Jul 17, 2023
@MSalopek MSalopek changed the title tests: handle liquid staked coins in sim; update sim ops test: handle liquid staked coins in sim; update sim ops Jul 17, 2023
Copy link
Collaborator

@sampocs sampocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for tackling this!

types/simulation/account.go Outdated Show resolved Hide resolved
@sampocs sampocs merged commit aa65e67 into iqlusioninc:v0.45.16-ics-lsm Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants