Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: probe and use local gateway if available #301

Closed
wants to merge 3 commits into from

Conversation

2color
Copy link
Member

@2color 2color commented Jun 18, 2024

Description

This PR checks if there's a local trustless gateway available (from IPFS Desktop or Kubo running on the user's machine) and adds it to the configuration.

Fixes #299

Adding it to the config on load is convoluted due to the way we persist and pass config from across origins into service workers.

Notes & open questions

  • In all my tests, I haven't been able to get the service worker to actually make requests to the local gateway. I couldn't find any such restriction in the service worker docs.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@lidel
Copy link
Member

lidel commented Jun 28, 2024

Continued in #303

@lidel lidel closed this Jun 28, 2024
@lidel lidel deleted the probe-local-gateway branch June 28, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ux: detect local trustless gw and default to it
2 participants