-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add information on the features supported by the public IPFS gateways #1877
Conversation
- Support one of the following libp2p transport configurations: | ||
- QUIC-v1 | ||
- TCP or WS or WSS, Yamux, TLS or Noise | ||
- WebTransport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebTransport is only for browsers as far as I'm aware.
- WebTransport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go-libp2p should support both receiving and dialing webtransport addresses (e.g. https://github.com/libp2p/go-libp2p/blob/6cebdd88366696a19b61dc209768c932a8f1ec4b/p2p/transport/webtransport/transport_test.go#L106)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool, but would be misleading. As far as I'm aware there's no reason a go peer would use WebTransport over QUIC. It would be misleading as it might wrongly suggest that browsers with WebTransport can be dialled over WebTransport.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I'm aware there's no reason a go peer would use WebTransport over QUIC
IIRC WebTransport would better help you hide you were using libp2p since it just looks like a regular HTTP/3 connection. However, independent of that some environments other than browsers might make WebTransport available before QUIC due to needing lower level access to QUIC (as opposed to WebTransport which for libp2p's case runs a Noise handshake on top to establish which PeerID is associated with the connection).
@2color any idea why this is failing with |
@aschmahmann Yeah it seems that this action is triggering some false positives, e.g. https://github.com/ipfs/ipfs-docs/actions/runs/8673131916/job/23935698662 I would just ignore it for this PR. |
@bumblefudge Try reviewing/merging #1886 first, I've fixed a bunch of broken links there, should make this one easier. |
41bd2c7
to
9855867
Compare
Co-authored-by: Marcin Rataj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, should be enough until we finish ipfs/specs#453 and refer to it here
Merged small suggestions, we can refine in follow-up PR.
Describe your changes
Given how much use and attention the public gateways provided by the IPFS Foundation get and how diverse IPFS implementations could be (https://specs.ipfs.tech/architecture/principles/#ipfs-implementation-requirements), it would be good to say explicitly what these public gateways support.
Information here is pretty rough but wanted to get something out. cc @darobin @lidel
Files changed
What issue(s) does this address?
Does this update depend on any other PRs?
No
Checklist before requesting a review
Checklist before merging