Expect all URL escapes to use uppercase hex (#232)

* Expect all URL escapes to use uppercase hex
ipfs · Jan 4, 2025 · cbb8832 · cbb8832
1 parent 7b383e6
commit cbb8832
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.7.1] - 2025-01-03
+### Changed
+- Expect all URL escapes to use uppercase hex [#232](https://github.com/ipfs/gateway-conformance/pull/232)
+
 ## [0.7.0] - 2025-01-03
 ### Changed
 - Update dependencies [#226](https://github.com/ipfs/gateway-conformance/pull/226) and [#227](https://github.com/ipfs/gateway-conformance/pull/227)

diff --git a/docs/test-dsl-syntax.md b/docs/test-dsl-syntax.md
@@ -10,7 +10,7 @@ for non-GO developers that want to read or contribute tests.
 
 golang's default string formating package is similar to C. Format strings might look like `"this is a %s"` where `%s` is a verb that will be replaced at runtime.
 
-These verbs collides with URL-escaping a lot, strings like `/ipfs/Qm.../%c4%85/%c4%99` might trigger weird errors. We implemented a minimal templating library that is used almost everywhere in the test.
+These verbs collides with URL-escaping a lot, strings like `/ipfs/Qm.../%C4%85/%C4%99` might trigger weird errors. We implemented a minimal templating library that is used almost everywhere in the test.
 
 It uses `{{name}}` as a replacement for `%s`. Other verbs are not supported.
 
@@ -28,7 +28,7 @@ Fmt(`Etag: W/"{{etag-value}}"`, "weak-key") // => "ETag: W/\"weak-key\""
 It is required to always provide a meaningful `{{name}}`:
 
 ```golang
-Fmt(`/ipfs/{{cid}}/%c4%85/%c4%99`, fixture.myCID) // => "/ipfs/Qm..../%c4%85/%c4%99"
+Fmt(`/ipfs/{{cid}}/%C4%85/%C4%99`, fixture.myCID) // => "/ipfs/Qm..../%C4%85/%C4%99"
 ```
 
 Values are replaced in the order they are defined, and you may reuse named values

diff --git a/tests/dnslink_gateway_test.go b/tests/dnslink_gateway_test.go
@@ -42,7 +42,7 @@ func TestDNSLinkGatewayUnixFSDirectoryListing(t *testing.T) {
 			Response: Expect().
 				Status(301).
 				Headers(
-					Header("Location").Equals(`/%c4%85/%c4%99/`),
+					Header("Location").Equals(`/%C4%85/%C4%99/`),
 				),
 		},
 		{