Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vsmgr): use bufio.Reader to avoid bufio.Scanner: token too long #232

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

dtynn
Copy link
Contributor

@dtynn dtynn commented Jun 10, 2022

关联的Issues (Related Issues)

fix #230

改动 (Proposed Changes)

使用 bufio.Reader + ReadBytes 实现 类似 Scanner.Scan 的结果,同时避免出现 bufio.Scanner: token too long 这样的问题

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 具有清晰明确的 commit message / All commits have a clear commit message.
  • 包含必要的测试用例 / This PR has tests for new functionality or change in behaviour
  • 包含必要的指南或文档 / If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included
  • 通过必要的检查项 / All checks are green

@dtynn dtynn added this to the v0.4.0 milestone Jun 10, 2022
@dtynn dtynn requested a review from diwufeiwen June 10, 2022 12:11
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit 658aea2 into main Jun 13, 2022
@diwufeiwen diwufeiwen deleted the fix/dtynn/use_bufio_reader_instead_of_scanner branch June 13, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[venus-sector-manager] ext-prover stdin 使用 bufio.Scanner 可能存在的问题
2 participants