Search and Grouping Feature #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
ipa-jsk
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Nice! The grouping feature could also be mentioned, what do you think?
There was a problem hiding this comment.
Nice idea! But there is no UI (yet) to set the group, right?
| @@ -379,17 +379,17 @@ def __init__(self, editor, element, style): | |||
| self.old_element = element | |||
|
|
|||
| if style == "plane": | |||
There was a problem hiding this comment.
Line 169 potentially should copy the group, too? (+duplicate button)
| @@ -190,13 +196,13 @@ def load_data(self, data): | |||
| f = Object_Mesh(name, position, orientation, frame["parent"], dat["package"], dat["path"], dat["scale"]) | |||
| f.set_color(color) | |||
| else: | |||
| f = Frame(name, position, orientation, frame["parent"]) | |||
| f = Frame(name, position, orientation, frame["parent"], group=group) | |||
There was a problem hiding this comment.
We should also add group to the SetFrame Service, shouldn't we?
| @@ -7,12 +7,14 @@ | |||
| import rospkg | |||
| import tf | |||
| import actionlib | |||
| import threading | |||
| # Clear the existing items in the tree | ||
| self.widget.list_tf.clear() | ||
|
|
||
| # Create root items for grouping (this is just an example) |
| # First, search in top-level items | ||
| top_level_items = self.widget.list_frames.findItems(name, Qt.MatchExactly) | ||
|
|
||
| # If not found at the top level, search recursively in child items |
There was a problem hiding this comment.
Technically, its not recursive ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
greyout orhideframes with argument--filter_style) (Addresses Last used frames on top #13 )groupattribute in the yaml fileFrames) and external frames (Other)