Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/cpuunclaimed: Remove unused python methods #5189

Merged
merged 1 commit into from
Jan 22, 2025
Merged

tools/cpuunclaimed: Remove unused python methods #5189

merged 1 commit into from
Jan 22, 2025

Conversation

kiraskyler
Copy link
Contributor

python methods getpid, system from os module unused at tools/cpuunclaimed

@kiraskyler kiraskyler force-pushed the master branch 2 times, most recently from 8541770 to 02f8cb1 Compare January 16, 2025 08:18
ekyooo
ekyooo reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@ekyooo ekyooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the change.
However, a better title would be:
'tools/cpuunclaimed: Remove unused python method imports'

thanks

tools/cpuunclaimed: Remove unused python method imports
d947085 
Remove unused python method imports

Signed-off-by: niuwanli <[email protected]>
@kiraskyler
Copy link
Contributor Author

LGTM for the change. However, a better title would be: 'tools/cpuunclaimed: Remove unused python method imports'

thanks

Thank you for your correction. I have revised it according to your recommendation

@yonghong-song yonghong-song merged commit 6878f24 into iovisor:master Jan 22, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekyooo ekyooo ekyooo left review comments

@brendangregg brendangregg Awaiting requested review from brendangregg brendangregg is a code owner

@goldshtn goldshtn Awaiting requested review from goldshtn goldshtn is a code owner

@davemarchevsky davemarchevsky Awaiting requested review from davemarchevsky davemarchevsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiraskyler @ekyooo @yonghong-song