cmake: Update GetGitRevisionDescription.cmake from upstream. #5186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpavlik
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
- Fixes operation when in a submodule or a secondary worktree. - Avoids potential issue where it would look for a git dir above CMAKE_SOURCE_DIR. - Update maintainer name/contact. Signed-off-by: Rylie Pavlik <[email protected]>
rpavlik
force-pushed
the
update-cmake-git
branch
from
165bf41 to
ac37fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it's me, the creator of that module, somehow one of my most widely known works! I keep finding it everywhere... 😅
It is true that this PR corrects the issues above, but TBH the primary reason I'm submitting this is to correct my name. (I found this project through the fact it is vendored into AOSP and thus shows up when I use android codesearch on my deadname.)
Hopefully I followed conventions correctly when creating this.
Thanks!