Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

[v2.0] Move exchange keys into User #251

Merged
merged 6 commits into from
Jun 2, 2022

Conversation

DyrellC
Copy link
Contributor

@DyrellC DyrellC commented May 31, 2022

Description of change

Remove exchange key management from KeyStore and rename to CursorStore. Exchange keys will now be hosted inside the User for now (will be removed later once #245 is addressed).

Addresses: #240

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

  • examples and tests continue to run with changes
  • cargo fmt/clippy/test

Copy link
Contributor

@arnauorriols arnauorriols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! I would say something about the method naming of CursorStore, but I assume they will change again the topic PR

streams/src/api/user.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@kwek20 kwek20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets clean this, then good to go!

streams/src/api/user.rs Outdated Show resolved Hide resolved
@kwek20 kwek20 merged commit 95c8646 into iotaledger:v2.0-dev Jun 2, 2022
@DyrellC DyrellC deleted the v2.0/move-keys branch March 13, 2023 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants