Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Output Builder allows setting Immutable Sender Feature #658

Closed
PhilippGackstatter opened this issue Jan 17, 2024 · 0 comments · Fixed by #661
Closed

Account Output Builder allows setting Immutable Sender Feature #658

PhilippGackstatter opened this issue Jan 17, 2024 · 0 comments · Fixed by #661
Assignees
Labels
bug team-node Issues for the Node Team
Milestone

Comments

@PhilippGackstatter
Copy link
Contributor

PhilippGackstatter commented Jan 17, 2024

Account Output Builder allow setting Immutable Sender Feature, which should not be allowed.

Also investigate why serix does not throw an error when serializing an Account with such a feature.

Reported here.

Anchor Output Builder allows setting Sender Feature which is also incorrect.

Also consider requiring the serial number to be set in NewFoundryOutputBuilder, since the default of 0 is always invalid and users need to set the serial number explicitly upon foundry creation.

@PhilippGackstatter PhilippGackstatter added bug team-node Issues for the Node Team labels Jan 17, 2024
@PhilippGackstatter PhilippGackstatter added this to the v1.0.0-beta milestone Jan 17, 2024
@PhilippGackstatter PhilippGackstatter changed the title Account Output Builder allow setting Immutable Sender Feature Account Output Builder allows setting Immutable Sender Feature Jan 17, 2024
@muXxer muXxer moved this to Backlog in iota-core Jan 18, 2024
@muXxer muXxer linked a pull request Jan 18, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Backlog to Done in iota-core Jan 18, 2024
@muXxer muXxer self-assigned this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug team-node Issues for the Node Team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants