Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serix: check registered interfaceObjects rules if the container is a slice of interfaces #660

Closed
muXxer opened this issue Jan 18, 2024 · 1 comment · Fixed by #662
Closed
Assignees
Labels
bug team-node Issues for the Node Team
Milestone

Comments

@muXxer
Copy link
Contributor

muXxer commented Jan 18, 2024

As mentioned in #658, serix doesn't check if the immutable features for an account output are valid.

This is because the AccountOutputImmFeatures are a slice of interfaces, and serix jumps into the encodeSlice code path, where it is never checked if the objects are registered for that interface.

@muXxer muXxer added this to iota-core Jan 18, 2024
@muXxer muXxer converted this from a draft issue Jan 18, 2024
@muXxer muXxer added the bug label Jan 18, 2024
@muXxer muXxer added this to the v1.0.0-beta milestone Jan 18, 2024
@muXxer muXxer added the team-node Issues for the Node Team label Jan 18, 2024
@muXxer
Copy link
Contributor Author

muXxer commented Jan 18, 2024

The problem was actually, that the Features[T] type ignored the T, so everything was a Feature instead of the specific features per output.

@muXxer muXxer linked a pull request Jan 18, 2024 that will close this issue
@muXxer muXxer self-assigned this Jan 18, 2024
@muXxer muXxer moved this from Backlog to In Progress in iota-core Jan 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in iota-core Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug team-node Issues for the Node Team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant