Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide to get NFTs Owned by an Account #1631

Merged
merged 8 commits into from
Jul 5, 2024

Conversation

Ginowine
Copy link
Contributor

@Ginowine Ginowine commented Jun 25, 2024

Description of change

Created a guide to demonstrate using the getL2NFTs function from the ISCAccounts.sol interface. It explains the function's purpose, operation within the ISCAccounts interface, and practical applications like portfolio management and marketplace listings.

Links to any relevant issues

fixes issue #1630

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@Ginowine Ginowine added the documentation Improvements or additions to documentation label Jun 25, 2024
@Ginowine
Copy link
Contributor Author

@lucas-tortora, this is a PR awaiting your awesomeness review, comments, suggestions, and any improvement you think is needed.

Copy link
Collaborator

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments regarding format, great article :)

@Ginowine Ginowine force-pushed the iota-wiki/guide-for-get-L2-NFTs branch from 24954f1 to b3636a0 Compare June 26, 2024 09:24
@Ginowine
Copy link
Contributor Author

@lucas-tortora, I have implemented your suggestions. Thanks for sharing them.

@lucas-tortora lucas-tortora marked this pull request as ready for review July 2, 2024 16:56
Copy link
Contributor

github-actions bot commented Jul 2, 2024

This pull request has been deployed to Vercel.

Latest commit: a03c4bc

✅ Preview: https://iota-wiki-88oainpac-iota1.vercel.app

Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this documented. Already helped one of our partners. Great job.

Just some smaller changes.
Don't forget to apply my changes on both pages

@Ginowine Ginowine force-pushed the iota-wiki/guide-for-get-L2-NFTs branch from a03c4bc to 00bb64a Compare July 5, 2024 10:27
@Dr-Electron Dr-Electron merged commit 8ed59c5 into main Jul 5, 2024
9 checks passed
@Dr-Electron Dr-Electron deleted the iota-wiki/guide-for-get-L2-NFTs branch July 5, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants