Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stronghold migration instructions #1078

Merged
merged 19 commits into from
Aug 17, 2023
Merged

Add Stronghold migration instructions #1078

merged 19 commits into from
Aug 17, 2023

Conversation

eike-hass
Copy link
Contributor

@eike-hass eike-hass commented Aug 3, 2023 •
edited
Loading

Description of change

Add migration instructions for Stronghold v2 to Identity 0.6.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Documentation Enhancement

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

PhilippGackstatter
PhilippGackstatter previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do what Abdul suggested and link to the function that can be used for the migration to make the CLI tool seem less mandatory to be used. But overall it's fine.

iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate_stronghold.mdx Outdated Show resolved Hide resolved
iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate_stronghold.mdx Outdated Show resolved Hide resolved
iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate_stronghold.mdx Outdated Show resolved Hide resolved
iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate_stronghold.mdx Outdated Show resolved Hide resolved
Dr-Electron
Dr-Electron reviewed Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting stuff. Docusaurus recommends to do it this way to not create any potential issues

iota/docs/identity.rs/v0.5.0/src/partials/_announcement.mdx Outdated Show resolved Hide resolved
iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate_stronghold.mdx Outdated Show resolved Hide resolved
iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate_stronghold.mdx Outdated Show resolved Hide resolved
iota/docs/identity.rs/v0.6.0/src/partials/_announcement.mdx Outdated Show resolved Hide resolved
@eike-hass
Copy link
Contributor Author

We could do what Abdul suggested and link to the function that can be used for the migration to make the CLI tool seem less mandatory to be used. But overall it's fine.

Both would be best probably.

eike-hass and others added 8 commits August 4, 2023 13:44
@eike-hass @Dr-Electron
Update iota/docs/identity.rs/v0.6.0/src/partials/_announcement.mdx
b031dad 
Co-authored-by: Dr-Electron <[email protected]>
@eike-hass @Dr-Electron
Update iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate_stronghold…
b4ab9c2 
….mdx

Co-authored-by: Dr-Electron <[email protected]>
@eike-hass @Dr-Electron
Update iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate_stronghold…
7b1b409 
….mdx

Co-authored-by: Dr-Electron <[email protected]>
@eike-hass @Dr-Electron
Update iota/docs/identity.rs/v0.5.0/src/partials/_announcement.mdx
f84ffc1 
Co-authored-by: Dr-Electron <[email protected]>
@eike-hass @PhilippGackstatter
Update iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate_stronghold…
9a4f621 
….mdx

Co-authored-by: Philipp Gackstatter <[email protected]>
@eike-hass @PhilippGackstatter
Update iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate_stronghold…
1519392 
….mdx

Co-authored-by: Philipp Gackstatter <[email protected]>
@eike-hass
add parameter docs
e1ba23e
@eike-hass
refine announcements
a8b5c0c
@Dr-Electron
Copy link
Collaborator

/create-preview

@Dr-Electron Dr-Electron force-pushed the chore/add-stronghold-migration-instructions branch from 3c33b55 to 571fdbe Compare August 7, 2023 15:36
@Dr-Electron
Copy link
Collaborator

/create-preview

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

This pull request has been deployed to Vercel.

Latest commit:

✅ Preview: https://iota-wiki-9qu557j7s-iota1.vercel.app

@eike-hass eike-hass marked this pull request as draft August 7, 2023 18:35
@eike-hass
Copy link
Contributor Author

/create-preview

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

This pull request has been deployed to Vercel.

Latest commit:

✅ Preview: https://iota-wiki-6nc106ada-iota1.vercel.app

@eike-hass
Copy link
Contributor Author

/create-preview

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

This pull request has been deployed to Vercel.

Latest commit:

✅ Preview: https://iota-wiki-24h06csnl-iota1.vercel.app

@eike-hass eike-hass requested a review from abdulmth August 8, 2023 11:40
@eike-hass
Copy link
Contributor Author

/create-preview

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

This pull request has been deployed to Vercel.

Latest commit:

✅ Preview: https://iota-wiki-fhnlx5mnz-iota1.vercel.app

@eike-hass
Copy link
Contributor Author

/create-preview

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

This pull request has been deployed to Vercel.

Latest commit:

✅ Preview: https://iota-wiki-eavuk94io-iota1.vercel.app

abdulmth
abdulmth reviewed Aug 8, 2023
View reviewed changes
iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate-stronghold.mdx Outdated Show resolved Hide resolved
iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate-stronghold.mdx Outdated Show resolved Hide resolved
iota/docs/identity.rs/v0.6.0/docs/tutorials/migrate-stronghold.mdx
- tutorials
---

import Announcement from '../../src/partials/_announcement.mdx';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the announcement here? It contains a link to the same page.

@eike-hass eike-hass changed the title WIP: Add Stronghold migration instructions Add Stronghold migration instructions Aug 17, 2023
@eike-hass eike-hass marked this pull request as ready for review August 17, 2023 15:14
@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d3fecb0

✅ Preview: https://iota-wiki-2acgk39k2-iota1.vercel.app

Dr-Electron
Dr-Electron approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was forced to do this. Help.

@Dr-Electron Dr-Electron merged commit 9eee1d5 into main Aug 17, 2023
18 checks passed
@Dr-Electron Dr-Electron deleted the chore/add-stronghold-migration-instructions branch August 17, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulmth abdulmth abdulmth left review comments

@Dr-Electron Dr-Electron Dr-Electron approved these changes

@PhilippGackstatter PhilippGackstatter PhilippGackstatter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eike-hass @Dr-Electron @PhilippGackstatter @abdulmth