Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK - Exchange Guide - Add Python and Rust Code #1064

Merged
merged 4 commits into from
Jul 26, 2023
Merged

SDK - Exchange Guide - Add Python and Rust Code #1064

merged 4 commits into from
Jul 26, 2023

Conversation

lucas-tortora
Copy link
Collaborator

Description of change

  • added rust and python code to the exchange guide
  • added api refs to the exchange guide
  • edited exchange-guide
  • fixed backup and security title

Links to any relevant issues

fixes https://github.com/iotaledger/devx/issues/171

Type of change

  • Documentation Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@lucas-tortora
* fixed backup and security title
377d4e0 
* added rust and python code to the exchange guide
* added api refs to the exchange guide
* edited exchange-guide
@lucas-tortora
fixes
d820a2a
@lucas-tortora lucas-tortora changed the title SDK - Add Python and Rust Code SDK - Exchange Guide - Add Python and Rust Code Jul 26, 2023
@lucas-tortora lucas-tortora marked this pull request as ready for review July 26, 2023 16:33
@lucas-tortora
Copy link
Collaborator Author

/create-preview

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d820a2a

✅ Preview: https://iota-wiki-knaj56n2o-iota1.vercel.app

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit:

✅ Preview: https://iota-wiki-2686ov7q5-iota1.vercel.app

Dr-Electron
Dr-Electron requested changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the stuff mentioned LGTM. Do we need a review from the SDK team?

shimmer/docs/iota-sdk/docs/how-tos/exchange-guide.mdx Outdated Show resolved Hide resolved
shimmer/docs/iota-sdk/docs/how-tos/exchange-guide.mdx Outdated Show resolved Hide resolved
@lucas-tortora lucas-tortora reopened this Jul 26, 2023
@Dr-Electron
Copy link
Collaborator

/create-preview

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit:

✅ Preview: https://iota-wiki-1wnhaht0o-iota1.vercel.app

@Dr-Electron Dr-Electron merged commit 89e0275 into main Jul 26, 2023
22 checks passed
@Dr-Electron Dr-Electron deleted the sdk/addTabsForPythonAndRustToExchangeGuide branch July 26, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Electron Dr-Electron Dr-Electron approved these changes

@anistark anistark Awaiting requested review from anistark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-tortora @Dr-Electron