Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add caching for private Tangle docker images #1079

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

eike-hass
Copy link
Collaborator

@eike-hass eike-hass commented Nov 15, 2022

Description of change

Add a caching layer for the docker images we pull for setting up the private tangle in every job. We expect those to change very unfrequently from run to run and it looks like we safe about ~70% runtime for ~150MB of cache.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tested in CI.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eike-hass eike-hass added Chore Tedious, typically non-functional change No changelog Excludes PR from becoming part of any changelog labels Nov 15, 2022
@eike-hass eike-hass requested a review from a team as a code owner February 6, 2024 16:27
@eike-hass eike-hass removed the request for review from PhilippGackstatter February 6, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant