Combine all CI into a single file and generate the matrix dynamically #4
reviewdog [golangci-runtime] report
reported by reviewdog 🐶
Findings (11)
runtime/reflect/get_caller.go|67 col 11| superfluous-else: if block ends with a break statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
runtime/reflect/get_caller.go|96 col 11| superfluous-else: if block ends with a break statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
runtime/syncutils/rwmultimutex.go|36 col 10| superfluous-else: if block ends with a goto statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
runtime/syncutils/rwmultimutex.go|48 col 11| superfluous-else: if block ends with a goto statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
runtime/syncutils/rwmultimutex.go|83 col 10| superfluous-else: if block ends with a goto statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
runtime/event/event.go|41 col 3| type assertion must be checked (forcetypeassert)
runtime/event/hook.go|30 col 3| type assertion must be checked (forcetypeassert)
runtime/syncutils/stack.go|46 col 9| type assertion must be checked (forcetypeassert)
runtime/syncutils/stack.go|74 col 9| type assertion must be checked (forcetypeassert)
runtime/timed/executor.go|77 col 5| type assertion must be checked (forcetypeassert)
runtime/timed/queue.go|184 col 3| type assertion must be checked (forcetypeassert)
Filtered Findings (0)
Annotations
Check failure on line 67 in runtime/reflect/get_caller.go
github-actions / golangci-runtime
[golangci-runtime] runtime/reflect/get_caller.go#L67
superfluous-else: if block ends with a break statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
Raw output
reflect/get_caller.go:67:11: superfluous-else: if block ends with a break statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
} else {
if frameCounter := len(callStack.frames); callStack.externalEntryPoint == 0 && path.Base(path.Dir(frame.File)) != packageName {
callStack.externalEntryPoint = frameCounter + skipCallers
}
callStack.frames = append(callStack.frames, frame)
frameCounter++
}
Check failure on line 96 in runtime/reflect/get_caller.go
github-actions / golangci-runtime
[golangci-runtime] runtime/reflect/get_caller.go#L96
superfluous-else: if block ends with a break statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
Raw output
reflect/get_caller.go:96:11: superfluous-else: if block ends with a break statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
} else {
fmt.Println(path.Base(path.Dir(frame.File)))
callers = append(callers, frame)
}
Check failure on line 36 in runtime/syncutils/rwmultimutex.go
github-actions / golangci-runtime
[golangci-runtime] runtime/syncutils/rwmultimutex.go#L36
superfluous-else: if block ends with a goto statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
Raw output
syncutils/rwmultimutex.go:36:10: superfluous-else: if block ends with a goto statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
} else {
if _, isRLocked := mutex.rLocks[identifier]; isRLocked {
for j := 0; j < i; j++ {
delete(mutex.wLocks, identifiers[j])
}
if i > 0 {
mutex.locksCond.Broadcast()
}
mutex.locksCond.Wait()
goto AcquireLocks
} else {
mutex.wLocks[identifier] = void
}
}
Check failure on line 48 in runtime/syncutils/rwmultimutex.go
github-actions / golangci-runtime
[golangci-runtime] runtime/syncutils/rwmultimutex.go#L48
superfluous-else: if block ends with a goto statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
Raw output
syncutils/rwmultimutex.go:48:11: superfluous-else: if block ends with a goto statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
} else {
mutex.wLocks[identifier] = void
}
Check failure on line 83 in runtime/syncutils/rwmultimutex.go
github-actions / golangci-runtime
[golangci-runtime] runtime/syncutils/rwmultimutex.go#L83
superfluous-else: if block ends with a goto statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
Raw output
syncutils/rwmultimutex.go:83:10: superfluous-else: if block ends with a goto statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
} else {
mutex.rLocks[identifier]++
}
Check failure on line 41 in runtime/event/event.go
github-actions / golangci-runtime
[golangci-runtime] runtime/event/event.go#L41
type assertion must be checked (forcetypeassert)
Raw output
event/event.go:41:3: type assertion must be checked (forcetypeassert)
e.preTriggerFunc = e.triggerSettings.preTriggerFunc.(TriggerFunc)
^
Check failure on line 30 in runtime/event/hook.go
github-actions / golangci-runtime
[golangci-runtime] runtime/event/hook.go#L30
type assertion must be checked (forcetypeassert)
Raw output
event/hook.go:30:3: type assertion must be checked (forcetypeassert)
h.preTriggerFunc = h.triggerSettings.preTriggerFunc.(TriggerFunc)
^
Check failure on line 46 in runtime/syncutils/stack.go
github-actions / golangci-runtime
[golangci-runtime] runtime/syncutils/stack.go#L46
type assertion must be checked (forcetypeassert)
Raw output
syncutils/stack.go:46:9: type assertion must be checked (forcetypeassert)
return b.elements.Remove(b.elements.Front()).(T), true
^
Check failure on line 74 in runtime/syncutils/stack.go
github-actions / golangci-runtime
[golangci-runtime] runtime/syncutils/stack.go#L74
type assertion must be checked (forcetypeassert)
Raw output
syncutils/stack.go:74:9: type assertion must be checked (forcetypeassert)
return b.elements.Remove(b.elements.Front()).(T), true
^
Check failure on line 77 in runtime/timed/executor.go
github-actions / golangci-runtime
[golangci-runtime] runtime/timed/executor.go#L77
type assertion must be checked (forcetypeassert)
Raw output
timed/executor.go:77:5: type assertion must be checked (forcetypeassert)
currentEntry.(func())()
^
Check failure on line 184 in runtime/timed/queue.go
github-actions / golangci-runtime
[golangci-runtime] runtime/timed/queue.go#L184
type assertion must be checked (forcetypeassert)
Raw output
timed/queue.go:184:3: type assertion must be checked (forcetypeassert)
polledElement := heap.Pop(&t.heap).(*generalheap.HeapElement[HeapKey, *QueueElement])
^