Move Encode/Decode to SerializableOrderedMap to prevent import loops #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muXxer
force-pushed
the
chore/use-our-orderedmap-impl
branch
2 times, most recently
from
a3a07f1
to
6e7e0ec
Compare
muXxer
force-pushed
the
chore/use-our-orderedmap-impl
branch
from
6e7e0ec
to
110699c
Compare
muXxer
changed the title
muXxer
force-pushed
the
chore/use-our-orderedmap-impl
branch
from
110699c
to
a4a8027
Compare
muXxer
force-pushed
the
chore/use-our-orderedmap-impl
branch
from
e971d59
to
e276609
Compare
PhilippGackstatter
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Encode/Decode functionality to a new type called
SerializableOrderedMap.This way we prevent import loops if we want to use our own
OrderedMapimplementation in serix.It also fixes a bug in the "update and commit" script that caused a wrong order of interdependencies between the submodules if the path of the submodule contained a version number.