Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serix struct tag changes #603

Merged
merged 17 commits into from
Nov 8, 2023
Merged

Serix struct tag changes #603

merged 17 commits into from
Nov 8, 2023

Conversation

muXxer
Copy link
Collaborator

@muXxer muXxer commented Nov 7, 2023 •
edited
Loading

  • Remove the serix "position" from the field tag
  • Use the first position as the fieldKey (former mapKey)
  • If fieldKey is empty, use camelCase with some exceptions (ID => Id, URL => Url, etc...)
  • Added maxByteSize
  • Rename some tags
    • lengthPrefixType => lenPrefix
    • nest=> inlined

piotrm50
piotrm50 reviewed Nov 8, 2023
View reviewed changes
ds/set_impl.go Outdated Show resolved Hide resolved
serializer/serializer.go Outdated Show resolved Hide resolved
serializer/serix/decode_test.go Outdated Show resolved Hide resolved
serializer/serix/encode_test.go Outdated Show resolved Hide resolved
serializer/serix/map_encode_test.go Outdated Show resolved Hide resolved
serializer/serix/serix.go Outdated Show resolved Hide resolved
@muXxer muXxer changed the base branch from develop to fix/serix-map-serialization November 8, 2023 09:15
@muXxer muXxer force-pushed the chore/rename-struct-tags branch 2 times, most recently from 339a88a to 4725f3d Compare November 8, 2023 15:26
@muXxer muXxer changed the base branch from fix/serix-map-serialization to develop November 8, 2023 15:55
@muXxer muXxer changed the base branch from develop to fix/serix-map-serialization November 8, 2023 15:57
@muXxer muXxer mentioned this pull request Nov 8, 2023
Closed
@muXxer muXxer changed the base branch from fix/serix-map-serialization to develop November 8, 2023 16:05
@muXxer muXxer merged commit bab2525 into develop Nov 8, 2023
52 checks passed
@muXxer muXxer deleted the chore/rename-struct-tags branch November 8, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrm50 piotrm50 piotrm50 left review comments

@alexsporn alexsporn alexsporn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muXxer @piotrm50 @alexsporn