Cleanup and housekeeping: remove unused code and fix linter warnings #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, bls, storable, dataflow
…t can be used in other components without an explicit type. This avoids type casting between types.Identifier and iota.go.Identifier
…code` needs to be refactored after the `stream` package is upgraded to its new API
jonastheis
force-pushed
the
cleanup/remove-unused-code
branch
from
40fe18c
to
8cb4535
Compare
alexsporn
force-pushed
the
cleanup/remove-unused-code
branch
from
5b30421
to
535733d
Compare
alexsporn
force-pushed
the
cleanup/remove-unused-code
branch
from
535733d
to
41d64fb
Compare
…typecasting when accesting the value
jonastheis
changed the title
alexsporn
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of unused code: objectstorage, thresholdmap, valuerange, identity, bls, storable, dataflow, some syncutils
It also removes types.Identifier and make it type constraint instead so that it can be used in other components without an explicit type. This avoids type casting between types.Identifier and iota.go.Identifier.
It enables the CI pipeline for linters and fixes all linter warnings as well