Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove tanglebay shimmer node from official nodes list #8562

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

Close #8561

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd self-assigned this Jun 24, 2024
@begonaalvarezd begonaalvarezd linked an issue Jun 24, 2024 that may be closed by this pull request
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node is updated correctly, but if it is as a primary node, the node remains.
I haven't had any problems with this, but maybe we should update it too, wdyt?
Captura de pantalla de 2024-06-25 11-33-09

@begonaalvarezd begonaalvarezd merged commit aff7776 into release/desktop-shimmer-2.1.16 Jun 25, 2024
4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/rm-smr-tanglebay branch June 25, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove tanglebay shimmer node
2 participants