Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better directions/error for missing Quake 3 / Team Arena pk3 files #634

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

zturtleman
Copy link

This adds better directions for what to do when Quake 3 or Team Arena pk3 files are missing. (Idea inspired by the org.ioquake3.ioquake3 Flatpak's message.)

The files to copy is set based on what files are missing and either a range ("pak3.pk3" through "pak8.pk3") or a list of a pk3s ("pak0.pk3", "pak7.pk3", and "pak8.pk3").

I tested it displayed okay on Linux (zenity), Windows, and macOS. I only took screenshots from Linux.

The error message contains a URL so I made the Windows fatal error dialog "copy to clipboard" option include the error message like Unix-like platform's crashlog.txt.

Existing message when missing all Quake 3 pk3 files:
Screenshot from 2024-01-21 15-32-53

New message:
Screenshot from 2024-01-21 15-05-05

Steam is (probably still) missing missionpack/pak3.pk3. Using pak[0-2].pk3 would show this message in ioquake3 when launching Team Arena:
Screenshot from 2024-01-21 15-12-38

New message:
Screenshot from 2024-01-21 15-09-23

The error was only displayed for Team Arena if one of the Team Arena pk3s
were found. Fix it to be display when trying to run Team Arena even with
no Team Arena pk3s present.
There is a copy to clipboard option but the error itself wasn't printed
to the console so it wasn't copied to the clipboard.

Unix-like platforms print it to the console so it's written in
crashlog.txt.
Copy link

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note that Zenity allows creating clickable links using HTML (at least with its GTK backend), as seen in yuzu:

Screenshot_20240121_025141

That said, in its current state, the text should be selectable already, so it's easy to copy and paste the URL.

@zturtleman zturtleman marked this pull request as draft May 20, 2024 19:58
@zturtleman
Copy link
Author

  • I still need to test the Linux kdialog and xmessage backends.
  • This is a fatal error and treated as an unsafe exit. The next time ioquake3 is run it offers to reset the video settings. This was already the case for baseq3 and when some missionpack pk3s exist. Though now it applies even if no missionpack pk3s exist. (I should probably leave this for a separate issue/PR.)

Note that Zenity allows creating clickable links using HTML
That said, in its current state, the text should be selectable already, so it's easy to copy and paste the URL.

ioquake3 doesn't know if Zenity will be used when the message text is set up. Clickable links would be nice but I'll pass on parsing and reallocating error messages. It is selectable to copy, yes.

@zturtleman zturtleman marked this pull request as ready for review August 28, 2024 21:50
@zturtleman
Copy link
Author

It also displays correctly (with multiple lines) in the Linux kdialog and xmessage backends.

@zturtleman zturtleman merged commit 7112bfb into ioquake:main Aug 28, 2024
3 checks passed
@zturtleman zturtleman deleted the missing_pk3s branch August 28, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants