Skip to content

Commit

Permalink
feat: remove the external flag for capacitor 7
Browse files Browse the repository at this point in the history
  • Loading branch information
damiant committed Jan 30, 2025
1 parent 3ccf3f6 commit 9bf56b9
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
## Changelog

### Version 1.102

- Remove the `--external` flag for Capacitor 7

### Version 1.101

- Capacitor 7 migration support
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "ionic",
"displayName": "Ionic",
"description": "Official extension for Ionic and Capacitor development",
"version": "1.101.0",
"version": "1.102.0",
"icon": "media/ionic.png",
"publisher": "Ionic",
"keywords": [
Expand Down
6 changes: 4 additions & 2 deletions src/capacitor-run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,10 @@ async function capRun(
const ionic = '';

if (externalIP) {
if (capRunFlags.length >= 0) capRunFlags += ' ';
capRunFlags += '--external';
if (isLess('@capacitor/core', '7.0.0')) {
if (capRunFlags.length >= 0) capRunFlags += ' ';
capRunFlags += '--external';
}
}

if (ionic != '' && prod) {
Expand Down

0 comments on commit 9bf56b9

Please sign in to comment.