Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V6 binding abstractions #1336

Draft
wants to merge 36 commits into
base: v6-binding-abstractions
Choose a base branch
from
Draft

V6 binding abstractions #1336

wants to merge 36 commits into from

Commits on May 4, 2021

  1. binding provideValue method

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    be130d8 View commit details
    Browse the repository at this point in the history

  2. create and assign value providers in bindingtosyntax

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    de71cf8 View commit details
    Browse the repository at this point in the history

  3. correct signatures

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    b492db3 View commit details
    Browse the repository at this point in the history

  4. FactoryTypeValueProvider

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    8f477a2 View commit details
    Browse the repository at this point in the history

  5. clone value provider

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    046e520 View commit details
    Browse the repository at this point in the history

  6. do not reset the binding scope when clone

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f232d52 View commit details
    Browse the repository at this point in the history

  7. remove non caching properties from Binding

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    7f1e6e6 View commit details
    Browse the repository at this point in the history

  8. Scope type

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    158b66a View commit details
    Browse the repository at this point in the history

  9. remove cache and activated from binding

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1a9e2e9 View commit details
    Browse the repository at this point in the history

  10. use InstanceValueProvider

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    145b113 View commit details
    Browse the repository at this point in the history

  11. give singleton scope clone same behaviours w.r.t rejecting promises

    @tonyhallett
    tonyhallett committed May 4, 2021
    Configuration menu
    Copy the full SHA
    0216d37 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. remove scope responsibility from value provider

    @tonyhallett
    tonyhallett committed May 5, 2021
    Configuration menu
    Copy the full SHA
    caf5f0f View commit details
    Browse the repository at this point in the history

  2. ScopeManager

    @tonyhallett
    tonyhallett committed May 5, 2021
    Configuration menu
    Copy the full SHA
    4d8de8d View commit details
    Browse the repository at this point in the history

  3. rename files to adhere to naming convention

    @tonyhallett
    tonyhallett committed May 5, 2021
    Configuration menu
    Copy the full SHA
    007c75b View commit details
    Browse the repository at this point in the history

  4. refactor planner - sub requests required as not instantiated

    @tonyhallett
    tonyhallett committed May 5, 2021
    Configuration menu
    Copy the full SHA
    3b9205b View commit details
    Browse the repository at this point in the history

  5. make valueproviderfactory public, hidden by interface

    @tonyhallett
    tonyhallett committed May 5, 2021
    Configuration menu
    Copy the full SHA
    c33a919 View commit details
    Browse the repository at this point in the history

  6. remaining value provider tests

    @tonyhallett
    tonyhallett committed May 5, 2021
    Configuration menu
    Copy the full SHA
    c60ad71 View commit details
    Browse the repository at this point in the history

  7. tests for 100% coverage

    @tonyhallett
    tonyhallett committed May 5, 2021
    Configuration menu
    Copy the full SHA
    1b5504b View commit details
    Browse the repository at this point in the history

  8. scope to return undefined instead of null

    @tonyhallett
    tonyhallett committed May 5, 2021
    Configuration menu
    Copy the full SHA
    b463a07 View commit details
    Browse the repository at this point in the history

  9. move scope tests from features to scope folder

    @tonyhallett
    tonyhallett committed May 5, 2021
    Configuration menu
    Copy the full SHA
    8472480 View commit details
    Browse the repository at this point in the history

  10. RootRequestScope ( and custom scope )

    @tonyhallett
    tonyhallett committed May 5, 2021
    Configuration menu
    Copy the full SHA
    a23684e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. move non public interfaces from interfaces

    @tonyhallett
    tonyhallett committed May 6, 2021
    Configuration menu
    Copy the full SHA
    6cc4aa4 View commit details
    Browse the repository at this point in the history

  2. rename test file to test file name

    @tonyhallett
    tonyhallett committed May 6, 2021
    Configuration menu
    Copy the full SHA
    5e59e82 View commit details
    Browse the repository at this point in the history

  3. value provider discriminated union

    @tonyhallett
    tonyhallett committed May 6, 2021
    Configuration menu
    Copy the full SHA
    20e8bc4 View commit details
    Browse the repository at this point in the history

  4. scope discriminated union and improve binding enums

    @tonyhallett
    tonyhallett committed May 6, 2021
    Configuration menu
    Copy the full SHA
    2b3f649 View commit details
    Browse the repository at this point in the history

  5. remove null as possible type of binding.valueProvider

    @tonyhallett
    tonyhallett committed May 6, 2021
    Configuration menu
    Copy the full SHA
    42cc523 View commit details
    Browse the repository at this point in the history

  6. remove BindingScopeScope from interfaces

    @tonyhallett
    tonyhallett committed May 6, 2021
    Configuration menu
    Copy the full SHA
    0361ee0 View commit details
    Browse the repository at this point in the history

  7. type tidy

    @tonyhallett
    tonyhallett committed May 6, 2021
    Configuration menu
    Copy the full SHA
    fcd4a8d View commit details
    Browse the repository at this point in the history

  8. NotConfiguredScope

    @tonyhallett
    tonyhallett committed May 6, 2021
    Configuration menu
    Copy the full SHA
    9d2f7bb View commit details
    Browse the repository at this point in the history

  9. reorder methods

    @tonyhallett
    tonyhallett committed May 6, 2021
    Configuration menu
    Copy the full SHA
    166b59e View commit details
    Browse the repository at this point in the history

  10. NotConfiguredValueProvider and correction of value provider cloning

    @tonyhallett
    tonyhallett committed May 6, 2021
    Configuration menu
    Copy the full SHA
    b7a8bc9 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. delete commented code

    @tonyhallett
    tonyhallett committed May 7, 2021
    Configuration menu
    Copy the full SHA
    cd534ba View commit details
    Browse the repository at this point in the history

  2. correct parameter type

    @tonyhallett
    tonyhallett committed May 7, 2021
    Configuration menu
    Copy the full SHA
    a8a4c30 View commit details
    Browse the repository at this point in the history

  3. context hierarchy options

    @tonyhallett
    tonyhallett committed May 7, 2021
    Configuration menu
    Copy the full SHA
    f772ebe View commit details
    Browse the repository at this point in the history

  4. add missing enum values

    @tonyhallett
    tonyhallett committed May 7, 2021
    Configuration menu
    Copy the full SHA
    9777284 View commit details
    Browse the repository at this point in the history

  5. correction to binding scope enums

    @tonyhallett
    tonyhallett committed May 7, 2021
    Configuration menu
    Copy the full SHA
    2d0be7e View commit details
    Browse the repository at this point in the history