Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CardPartPagedView.swift #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jjburka
Copy link

@jjburka jjburka commented Feb 24, 2020

Update currentPage to use moveToPage.
Add animated param to moveToPage

Before you make a Pull Request, read the important guidelines:

Issue Link 🔗

  • Is this a bug fix or a feature? Bugfix
  • Does it break any existing functionality? No

Goals of this PR 🎉

How Has This Been Tested 🔍

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

  • User Interface Testing
  • Application Testing

Test Configuration 👾

  • Xcode version:
  • Device/Simulator
  • iOS version || MacOSX version

Things to check on 🎯

  • My Pull Request code follows the coding standards and styles of the project
  • I have worked on unit tests and reviewed my code to the best of my ability
  • I have used comments to make other coders understand my code better
  • My changes are good to go without any warnings
  • I have added unit tests both for the happy and sad path
  • All of my unit tests pass successfully before pushing the PR
  • I have made sure all dependent downstream changes impacted by my PR are working

Update currentPage to use moveToPage.
Add animated param to moveToPage
@jjburka jjburka requested a review from croossin February 25, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CardPartPagedView doesn't scroll content when currentPage is set.
1 participant